From 3fea379ff56e28600ec70fbabfa0392cf8dfac08 Mon Sep 17 00:00:00 2001 From: Steven Schubiger Date: Mon, 20 Jun 2016 21:07:37 +0200 Subject: Extract fail tests to test file --- t/fail.t | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ test.pl | 52 ++--------------------------------------- 2 files changed, 83 insertions(+), 50 deletions(-) create mode 100755 t/fail.t diff --git a/t/fail.t b/t/fail.t new file mode 100755 index 0000000..b7f0dcb --- /dev/null +++ b/t/fail.t @@ -0,0 +1,81 @@ +#!/usr/bin/perl + +use strict; +use warnings; +use constant true => 1; +use constant false => 0; + +use File::Temp qw(tempfile tempdir tmpnam); +use IPC::Open3 qw(open3); +use Symbol qw(gensym); +use Test::More; + +my $tests = 20; + +my $source = 'colorize.c'; +my $compiler = 'gcc'; + +my $write_to_tmpfile = sub +{ + my ($content) = @_; + + my ($fh, $tmpfile) = tempfile(UNLINK => true); + print {$fh} $content; + close($fh); + + return $tmpfile; +}; + +my $run_program_fail = sub +{ + my ($program, $args, $message) = @_; + + my @args = split /\s+/, $args; + + my $err = gensym; + + my $pid = open3(gensym, gensym, $err, $program, @args); + waitpid($pid, 0); + + my $output = do { local $/; <$err> }; + + return ($? >> 8 == 1 && $output =~ /$message/) ? true : false; +}; + +plan tests => $tests; + +SKIP: { + my $program = tmpnam(); + skip 'compiling failed (failure exit)', $tests unless system("$compiler -DTEST -o $program $source") == 0; + + my $file = $write_to_tmpfile->('abc'); + my $dir = tempdir(CLEANUP => true); + + my @set = ( + [ '--exclude-random=random', 'must be provided a plain color' ], + [ '--clean --clean-all', 'mutually exclusive' ], + [ '--clean file1 file2', 'more than one file' ], + [ '--clean-all file1 file2', 'more than one file' ], + [ '- file', 'hyphen cannot be used as color string' ], + [ '-', 'hyphen must be preceeded by color string' ], + [ "$file file", 'cannot be used as color string' ], + [ "$file", 'must be preceeded by color string' ], + [ "$dir", 'is not a valid file type' ], + [ '/black', 'foreground color missing' ], + [ 'white/', 'background color missing' ], + [ 'white/black/yellow', 'one color pair allowed only' ], + [ 'y3llow', 'cannot be made of non-alphabetic characters' ], + [ 'yEllow', 'cannot be in mixed lower/upper case' ], + [ 'None', 'cannot be bold' ], + [ 'white/Black', 'cannot be bold' ], + [ 'random/none', 'cannot be combined with' ], + [ 'random/default', 'cannot be combined with' ], + [ 'none/random', 'cannot be combined with' ], + [ 'default/random', 'cannot be combined with' ], + ); + foreach my $set (@set) { + ok($run_program_fail->($program, $set->[0], $set->[1]), $set->[1]); + } + + unlink $program; +} diff --git a/test.pl b/test.pl index 40c3cb5..570a7b7 100755 --- a/test.pl +++ b/test.pl @@ -5,13 +5,11 @@ use warnings; use constant true => 1; use constant false => 0; -use File::Temp qw(tempfile tempdir tmpnam); -use IPC::Open3 qw(open3); -use Symbol qw(gensym); +use File::Temp qw(tempfile tmpnam); use Test::Harness qw(runtests); use Test::More; -my $tests = 25; +my $tests = 24; my %BUF_SIZE = ( normal => 1024, @@ -52,52 +50,6 @@ SKIP: { is(system("$program --help >/dev/null 2>&1"), 0, 'exit value for help screen'); is(system("$program --version >/dev/null 2>&1"), 0, 'exit value for version data'); - my $run_program_fail = sub - { - my ($program, $args, $message) = @_; - - my @args = split /\s+/, $args; - - my $err = gensym; - - my $pid = open3(gensym, gensym, $err, $program, @args); - waitpid($pid, 0); - - my $output = do { local $/; <$err> }; - - return ($? >> 8 == 1 && $output =~ /$message/) ? true : false; - }; - - { - my $ok = true; - - my $file = $write_to_tmpfile->('abc'); - my $dir = tempdir(CLEANUP => true); - - $ok &= $run_program_fail->($program, '--exclude-random=random', 'must be provided a plain color'); - $ok &= $run_program_fail->($program, '--clean --clean-all', 'mutually exclusive'); - $ok &= $run_program_fail->($program, '--clean file1 file2', 'more than one file'); - $ok &= $run_program_fail->($program, '--clean-all file1 file2', 'more than one file'); - $ok &= $run_program_fail->($program, '- file', 'hyphen cannot be used as color string'); - $ok &= $run_program_fail->($program, '-', 'hyphen must be preceeded by color string'); - $ok &= $run_program_fail->($program, "$file file", 'cannot be used as color string'); - $ok &= $run_program_fail->($program, "$file", 'must be preceeded by color string'); - $ok &= $run_program_fail->($program, "$dir", 'is not a valid file type'); - $ok &= $run_program_fail->($program, '/black', 'foreground color missing'); - $ok &= $run_program_fail->($program, 'white/', 'background color missing'); - $ok &= $run_program_fail->($program, 'white/black/yellow', 'one color pair allowed only'); - $ok &= $run_program_fail->($program, 'y3llow', 'cannot be made of non-alphabetic characters'); - $ok &= $run_program_fail->($program, 'yEllow', 'cannot be in mixed lower/upper case'); - $ok &= $run_program_fail->($program, 'None', 'cannot be bold'); - $ok &= $run_program_fail->($program, 'white/Black', 'cannot be bold'); - - foreach my $color_pair (qw(random/none random/default none/random default/random)) { - $ok &= $run_program_fail->($program, $color_pair, 'cannot be combined with'); - } - - ok($ok, 'exit messages/values for failures'); - } - is(qx(printf '%s\n' "hello world" | $program none/none), "hello world\n", 'line read from stdin with newline'); is(qx(printf %s "hello world" | $program none/none), "hello world", 'line read from stdin without newline'); -- cgit v1.2.3