From ef3ba3bb9a06cffad7b4530a88f36b871abe2e0d Mon Sep 17 00:00:00 2001 From: Steven Schubiger Date: Wed, 2 Aug 2017 11:07:02 +0200 Subject: Optimize extracting invalid attribute name --- colorize.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'colorize.c') diff --git a/colorize.c b/colorize.c index 1e27fca..8c0afcb 100644 --- a/colorize.c +++ b/colorize.c @@ -469,11 +469,10 @@ process_opt_attr (const char *p) } if (!valid_attr) { - char *sep; - char *attr_invalid = xstrdup (s); + char *attr_invalid = xmalloc ((p - s) + 1); STACK_VAR (attr_invalid); - if ((sep = strchr (attr_invalid, ','))) - *sep = '\0'; + strncpy (attr_invalid, s, p - s); + attr_invalid[p - s] = '\0'; vfprintf_fail ("--attr switch attribute '%s' is not valid", attr_invalid); } } -- cgit v1.2.3